ci(Travis): updates Travis validations #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Validate against current node versions - Test against both Webpack 1.4.x & 2.2.x - Remove deprecated .eslintrc - .eslint.yml generated from current code ( no changes ) - add yarn lock file set to binary in git - ignores console for eslint in test helpers
Current coverage is 98.35% (diff: 100%)@@ master #408 diff @@
==========================================
Files 9 9
Lines 304 304
Methods 41 41
Messages 0 0
Branches 67 67
==========================================
Hits 299 299
Misses 5 5
Partials 0 0
|
|
Thank you. I'm glad to see we have our linter and standards added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Travis Build & Validations
Summary
Currently css-loader runs tests against Node v0.12 | v7.40 | io.js v3.3.1 and does not target a specific webpack version ( currently latest is 1.14.x ).
Updates the Travis matrix to test against all currently supported Node versions
Adds a single lint validation executed on Nodejs@latest
Does this PR introduce a breaking change?
Other information
This is a step towards adding the ability to run benchmark tests and use newer language features via babel which can't be done realistically until existing PRs are cleared.