Skip to content

refactor: improve resolving #1327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jul 14, 2021
Merged

refactor: improve resolving #1327

merged 19 commits into from
Jul 14, 2021

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jul 14, 2021

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

avoid unnecessary resolving for new URL syntax

Breaking Changes

  • used new URL() syntax, instead import when esModules: true
  • alias.resolve with false value now generate empty dataURI, please use url.filter to keep URLs as is
  • ~ is depreacted but still supported, you can safely remove ~ from your code, due logic prefer relative then prefer absolute (only for esModules: true)
  • css-loader will be faster if you enable esModules (true by default)

Additional Info

fixes #1246, only when you use esModules: true

@codecov
Copy link

codecov bot commented Jul 14, 2021

Codecov Report

Merging #1327 (db9a20b) into next (946a5a1) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #1327      +/-   ##
==========================================
+ Coverage   98.34%   98.36%   +0.02%     
==========================================
  Files          11       11              
  Lines         965      977      +12     
  Branches      321      330       +9     
==========================================
+ Hits          949      961      +12     
  Misses         13       13              
  Partials        3        3              
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)
src/plugins/postcss-url-parser.js 97.70% <100.00%> (+0.06%) ⬆️
src/utils.js 97.65% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946a5a1...db9a20b. Read the comment docs.

@alexander-akait alexander-akait merged commit 3275ef0 into next Jul 14, 2021
@alexander-akait alexander-akait deleted the issue-1246 branch July 14, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant