Skip to content

refactor: removed compileType option in favor mode option #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2021

Conversation

cap-Bernardito
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Reduced options
Removed compileType option in favor mode option

Breaking Changes

  • compileType: "module" removed in favor mode: "local", "global" or "pure"
  • compileType: "icss" removed in favor mode: "icss"

Additional Info

No

@cap-Bernardito cap-Bernardito changed the base branch from master to next May 5, 2021 12:06
@codecov
Copy link

codecov bot commented May 5, 2021

Codecov Report

Merging #1302 (6ccd4d2) into next (1c3d9ad) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1302   +/-   ##
=======================================
  Coverage   98.30%   98.31%           
=======================================
  Files          11       11           
  Lines         886      888    +2     
  Branches      296      297    +1     
=======================================
+ Hits          871      873    +2     
  Misses         12       12           
  Partials        3        3           
Impacted Files Coverage Δ
src/utils.js 97.45% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3d9ad...6ccd4d2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants