Skip to content

Escaped characters in CSS content are not respected #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chandlervdw opened this issue Sep 3, 2015 · 12 comments · Fixed by css-modules/css-selector-tokenizer#13
Closed

Comments

@chandlervdw
Copy link

Even though this was listed in #87 and supposedly fixed by css-modules/css-selector-tokenizer@5aa6180, I'm still having this issue.

content: "\A"; is compiled to content: "A";, so the \ character isn't being parsed correctly...

@chandlervdw
Copy link
Author

@andreypopp @JackVCurtis @mathieumg are any of you still able to reproduce this issue?

@chandlervdw
Copy link
Author

I have no idea why this worked but putting content: '\"\A'; fixed it. It outputs as content: '\"\A'; but somehow still renders as a line break. I'm sure this will break soon...

@chandlervdw
Copy link
Author

Ok, nevermind, that does NOT work.

@robmcguinness
Copy link

content: '\0000a0'; is being converted to content: 'A 0';. Downgrading to v0.14.5 fixes the issue for me.

@chandlervdw
Copy link
Author

Any word on this? I hate keeping this lib at v0.14.5.

@robmcguinness
Copy link

@chandlervdw my workaround was to alter content value to work with v0.14.5+

image

@chandlervdw
Copy link
Author

@robmcguinness I'm trying to achieve an end value of \A ... can you advise me on what I should change my content value to?

@robmcguinness
Copy link

@chandlervdw I haven't dug into the code in a while but if I get a minute i'll take a peek

@pieter
Copy link

pieter commented Apr 12, 2016

Traced the problem to css-modules/css-selector-tokenizer#12

pieter pushed a commit to pieter/css-selector-tokenizer that referenced this issue Apr 13, 2016
This fixes the parsing of unicode strings that are 1 or 6
hex characters long.

Extends the tests to support a third element in examples, which
would be the re-stringified example, since a unicode character might
be stringified in a different way than the original code, and still be
valid.

fixes webpack-contrib/css-loader#133
fixes css-modules#12
pieter added a commit to pieter/css-selector-tokenizer that referenced this issue Apr 13, 2016
This fixes the parsing of unicode strings that are 1 or 6
hex characters long.

Extends the tests to support a third element in examples, which
would be the re-stringified example, since a unicode character might
be stringified in a different way than the original code, and still be
valid.

fixes webpack-contrib/css-loader#133
fixes css-modules#12
@h6ah4i
Copy link

h6ah4i commented Jun 16, 2016

+1

@kencana-voilaah
Copy link

hi guys, encountering same issue, any tweak i should do to make it work for now?

tadjohnston added a commit to tadjohnston/css-loader that referenced this issue Jul 25, 2016
@tadjohnston
Copy link
Contributor

Added a PR to bump thecss-selector-tokenizer version to 0.6.0.

sokra added a commit that referenced this issue Jul 26, 2016
Fixes issue #133 with unicode strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants