feat: add command execution again #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned on actions/toolkit#702 (comment), we are safe to execute commands on our side. This reverts commit 58072cd, reversing changes made to 1788ebd.
wagoid
force-pushed
the
feat/add-command-execution-again
branch
from
6a0df16 to
a34ac47
Compare
jdbruijn
reviewed
Feb 7, 2021
| @@ -135,9 +134,7 @@ const showLintResults = async ([from, to]) => { | |||
| ) | |||
| const formattedResults = formatErrors(lintedCommits) | |||
|
|
|||
| // disable workflow commands | |||
| const token = uuidv4() | |||
There was a problem hiding this comment.
The uuidv4 dependency can be removed from this file, also as npm package if it is not used elsewhere.
There was a problem hiding this comment.
Nice catch! I see it's been even updated on #76, will merge that one. It's also about time to add eslint to this project, will add later on 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #70