add excludeTargetBranch input option #656
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelgwelch
commented
Jan 27, 2023
| branch will be linted again. Set this to `true` to avoid that. | ||
|
|
||
| TODO: This explanation can be made better when I better understand why `--firstParent` alone didn't resolve this. | ||
| To do that I need to understand what `git log <revision range>` is doing. |
There was a problem hiding this comment.
Likewise, the better explanation can go above as well.
michaelgwelch
commented
Jan 27, 2023
| TODO: This explanation can be made better when I better understand why `--firstParent` alone didn't resolve this. | ||
| To do that I need to understand what `git log <revision range>` is doing. | ||
| default: "false" | ||
| required: false |
There was a problem hiding this comment.
if we understand the root problem better, then perhaps this should default to true much like firstParent.
michaelgwelch
commented
Jan 27, 2023
| @@ -78,6 +78,10 @@ function getHistoryCommits(from, to) { | |||
| options.firstParent = true | |||
| } | |||
|
|
|||
| if (getInput('excludeTargetBranch') === 'true') { | |||
| options[`^${GITHUB_BASE_REF}`] = true | |||
| } | |||
There was a problem hiding this comment.
Not 100% certain I have the correct variable here since this code has literally never run. (See comment in description about "how to test")
|
Based on my discover and later comment #456 (comment) , I think this PR should be closed and instead I could submit a PR where we use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to figure out how to test my changes.
Regarding #1: It seems that your version runs instead of mine (even though in my test repo I'm specifically pulling in my version). I assume this is because it downloads and uses your docker image (which I assume has your version of this action in it, or it specifically pulls down your version and runs it).
If you can give me a pointer on how to test this (I don't have a lot of experience writing workflows or custom actions).
Fixes #456 (or will after tested, reviewed, and corrected if necessary)