Skip to content

Improve data model diagram with examples showing different encodings. #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 26, 2018

Conversation

gkellogg
Copy link
Member

This should fix #29.

@gkellogg gkellogg requested a review from iherman September 24, 2018 21:20
@gkellogg
Copy link
Member Author

@iherman The updated graph, now complete with an example in different syntaxes, does illustrate the use of @graph at the top level to describe something like a "bush". Let me know if you think that it is sufficient, or how you'd like to change the figure.

@gkellogg gkellogg force-pushed the illustrate-complex-graph branch 2 times, most recently from b3c1f9c to 4d17c84 Compare September 25, 2018 00:15
"@id": "graphs/2",
"@graph": {
"@id": "people/bob",
"sibling": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although RDF-wise correct, but why this double sibling layer? what is wrong wit

"@graph":{
"@id" : "people/bob",
"sibling":{
"name":"mary",
"@id":"people/mary",
"sibling":{"@id":"people/bob"
}
}

The current two layer structure is only messing up the reader imho...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I we trying to give reasonable labels to the pre-existing triangular graph, but perhaps it’s better to simply remove a layer.

@gkellogg gkellogg force-pushed the illustrate-complex-graph branch from 4d17c84 to 72739af Compare September 26, 2018 19:09
@gkellogg gkellogg merged commit 7071295 into master Sep 26, 2018
@gkellogg gkellogg deleted the illustrate-complex-graph branch September 26, 2018 19:33
@iherman iherman mentioned this pull request Feb 14, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Illustration of the data model: a more complex graph?
2 participants