-
Notifications
You must be signed in to change notification settings - Fork 23
Add a section on using HTML documents for contexts (and frames). #167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
SpecGen is having some problems, you can find a preview here, sorry, no diffs, but changes are mostly in the "Using an HTML document as a Context" section and a paragraph at the end of "Framed Document Form". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a first-time reader of that section it is not explicitly said in the text that a frame document is also a bona fide JSON-LD document. This is implicit by the fact that the two sections at the end (the new one and the previous one) refers to the JSON-LD profile; I think it should make it explicit in the text.
Obviously, this is not a comment on the new paragraph, but on the section as a whole. I am fine with the changes proper.
spec-generator is indeed timing out on large documents. I submitted a PR to increase the timeout: |
It's now merged and deployed. |
…g JSON-LD embedded in HTML.
@iherman, I put the Processor Levels section within Conformance, which I think is appropriate. |
Isn't it a bit risky to have two normative definitions of the same terms live in two different files? I think we should at least have a comment in both files to remind our future selves (and future editors) that any update in one of the files should be reflected in the other... WDYT? |
I can update the definitions in the context to reference the definitions in the syntax document easily enough. Doesn't change the way the text reads, but dereferences will go the the syntax versions. |
See w3c/json-ld-api#84. |
@gkellogg sorry I missed reviewing this before the merge. I'm still concerned that we explain |
I was also thinking to beef up the Document Loader section and move most of the logic there, having the document loader return the JSON structure resulting from dereferencing the document. This also provides a means of describing other ways a custom document loader might handle IRIs without actual dereference. |
For w3c/json-ld-api#66.
Preview | Diff