Skip to content

Expand compaction section #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2019
Merged

Expand compaction section #131

merged 5 commits into from
Feb 21, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 19, 2019

…different term definitions on compaction. This includes describing @type: @none.

For w3c/json-ld-api#33.


Preview | Diff

…different term definitions on compaction. This includes describing `@type: @none`.

For w3c/json-ld-api#33.
@gkellogg
Copy link
Member Author

Work is incomplete for more descriptions of compaction, but the bit on @type: @none is in. Please comment.

@iherman
Copy link
Member

iherman commented Feb 19, 2019

Mini-mini editorial comment: it would be good to use a non-breaking space character between a "§" and the number. I get lines with a "§" at the end of the line and the number at the beginning of the next line; it does look strange...

@iherman
Copy link
Member

iherman commented Feb 19, 2019

Just an aesthetic issue... In example 105 you say:

"http://example.com/iri": [
    {"@id": "http://example.org/iri"}
  ]

Maybe it is nicer to use a different URI for the term and its value :-)

@iherman
Copy link
Member

iherman commented Feb 19, 2019

In example 106 you say:

Note that there is no term defined for "plain", that is created automatically using the vocabulary mapping.

I am not sure what this refers to. In the example, "plain" is a simple text, and stays that way. Is this a leftover from a different example?

@gkellogg
Copy link
Member Author

Mini-mini editorial comment: it would be good to use a non-breaking space character between a "§" and the number. I get lines with a "§" at the end of the line and the number at the beginning of the next line; it does look strange...

That would be an issue for ReSpec, which added the "§” recently.

@iherman
Copy link
Member

iherman commented Feb 19, 2019

That would be an issue for ReSpec, which added the "§” recently.

Ah. I have raised https://github.com/w3c/respec/issues/2109.

Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good for me, appart for a few typos for which I'm about to push a commit.

@gkellogg gkellogg marked this pull request as ready for review February 19, 2019 22:39
@gkellogg gkellogg merged commit 63627cf into master Feb 21, 2019
@gkellogg gkellogg deleted the issue-124-editorial-issues branch February 21, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants