-
Notifications
You must be signed in to change notification settings - Fork 35
Add protected term redefinition tests. #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9a36fd8
to
0a058f8
Compare
@davidlehn, can you resolve the conflict? |
0a058f8
to
dd95cc3
Compare
@dlongley Fixed. |
@davidlehn, thanks! |
5c1f3c4
to
519eba7
Compare
…cal protected terms. Note that the algorithm sets terms to `null` in context if they're defined as `null` or `{"@id": null}` and doesn't retain the protected status, which it probably should.
@dlongley note the comment in the last commit: "Note that the algorithm sets terms to If you agree, I'll update that part too. |
It does seem like it should to retain protected status, i.e. what we're saying is that we'd allow for terms to be defined as null and protect that null definition, right? I know we have some other issue about it perhaps doing that for prefixes for security purposes. We'd have to implement it to make sure it doesn't do anything strange or break any existing tests. We would also need new tests to check it. Have you happened to have implemented it and run it against the existing tests? |
My implementation does create an empty We should update step 5.4 in IRI Expansion to not use a term as a Compact IRI prefix if it's IRI mapping is |
A few of these tests look a bit crazy. Sorry. ;-) Suggested improvements would be welcome.
Preview | Diff