Skip to content

Add support for @type: @none in term definitions. #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 17, 2019

  • Updates value expansion and value compaction, inverse contexts, and term selection.
  • Causes all value objects which are not compacted away to have their keywords and value of @type compacted.

For #33.


Preview | Diff

* Updates value expansion and value compaction, inverse contexts, and term selection.
* Causes all value objects which are not compacted away to have their keywords and value of `@type` compacted.
@gkellogg
Copy link
Member Author

This still requires changes to describe this feature in the syntax document.

Copy link
Contributor

@azaroth42 azaroth42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looks good, other than one @null instead of @none. Agree it needs description in the syntax doc.

@gkellogg gkellogg marked this pull request as ready for review February 19, 2019 22:40
@gkellogg gkellogg merged commit 8f276ca into master Feb 20, 2019
@gkellogg gkellogg deleted the issue-33-type-none branch February 20, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants