Fix compacting property-based indexes. #528
Conversation
…n't like the anchor link style anymore.
… to first expand container key before compacting it. Fixes #514.
| <li>Reinitialize <var>container key</var> by <a>IRI compacting</a> | ||
| <var>index key</var>.</li> | ||
| <li id="alg-compact-12_8_9_6_1">Reinitialize <var>container key</var> by <a>IRI compacting</a> | ||
| <var>index key</var> after first <a>IRI expanding</a> it.</li> |
There was a problem hiding this comment.
An alternative to consider, which is probably more correct, would be to do the expansion of the @index value when the context is processed, as the value may expand differently than it would when compacting. It would still be a localized change, but not to the Compaction algorithm.
There was a problem hiding this comment.
I did try this, but remembering the original compacted term is necessary for expansion. The most correct solution would be to save the expanded version of this in the term definition, and use that in the Compaction algorithm instead of the original version, but that would be more disruptive to the rest of the document. This solution will solve any issues other than those specifically constructed to defeat it.
The value of
@indexon a property map can be a Compact IRI in addition to an IRI. The Compaction Algorithm is updated to first expand this value before re-compacting it. Added additional language to the Compaction Algorithm step 12.8.9.6.1 to first expand container key before compacting it.Also fixed an emergent issue with WebIDL reference for LoadDocumentCallback/url.
Adds two new compaction tests.
Fixes #514.
CC/ @vcharpenay
Preview | Diff