Skip to content

Add tests and spec text for scoped-contexts on @nest alias. #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 16, 2020
Merged

Add tests and spec text for scoped-contexts on @nest alias. #388

merged 8 commits into from
Nov 16, 2020

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Feb 23, 2020 •
edited by pr-preview bot
Loading

For #380

Preview | Diff

@gkellogg gkellogg mentioned this pull request Feb 23, 2020
Open
pchampin
pchampin reviewed Feb 24, 2020
View reviewed changes
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, although as suggested in my 2nd comment, I don't see why we would now support scoped context for nests, and still not support local contexts...

@pchampin pchampin mentioned this pull request Feb 25, 2020
Open
@gkellogg gkellogg added the defer-future-version Defer this issue until a future version of JSON-LD label Feb 28, 2020
@gkellogg gkellogg requested a review from pchampin November 14, 2020 19:29
pchampin
pchampin approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me.

@gkellogg gkellogg merged commit d61c842 into master Nov 16, 2020
@gkellogg gkellogg deleted the issue-380 branch November 16, 2020 18:27
@BigBlueHat BigBlueHat added spec:editorial class-3 Class-3 change and removed defer-future-version Defer this issue until a future version of JSON-LD labels Oct 16, 2024
gkellogg added a commit that referenced this pull request Oct 18, 2024
@gkellogg
Add candidate change and insertions for #380/#388.
8d0b7b5
@gkellogg gkellogg mentioned this pull request Oct 18, 2024
Merged
gkellogg added a commit that referenced this pull request Oct 24, 2024
@gkellogg
Add candidate change and insertions relating to previously merged cla…
b8ac517 
…ss-3 changes. (#616)

* Add candidate change and insertions for #380/#388.
* Reorder change details with newest first.
* Comment out 2021-01-05 editorial changes to node-map-generation algorithm.
* Comment out 2021-02-25 editorial changes to IRI expansion algorithm.
* Add Candidate Correction 2 for issue #514.
* CANDIDATE CORRECTION 3 for issue 565, PR 566 to "Fix context processing for reverse terms".
* CANDIDATE CORRECTION 4 for `extractAllScripts` option to `toRdf()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchampin pchampin pchampin approved these changes

@davidlehn davidlehn Awaiting requested review from davidlehn

Assignees
No one assigned
Labels
class-3 Class-3 change spec:editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkellogg @pchampin @BigBlueHat