Skip to content

Updates to pass base URL #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 29, 2020
Merged

Updates to pass base URL #356

merged 6 commits into from
Jan 29, 2020

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jan 27, 2020

to Expansion, Context Processing and Create Term definition.

The change touches a lot of parts, and leaves a little hand waiving when a context has been previously loaded.

For #265.


Preview | Diff

Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appart from the duplicate 'context' in the definition of "term definition", looks good.

gkellogg and others added 4 commits January 28, 2020 13:30
…e original documentUrl containing the top-most context. This is initialized in `expand()` and when a _local context_ is `null`.
@davidlehn
Copy link
Contributor

Commit message should be "Update JCS", not "Update jsonld.js":
2614999

@gkellogg
Copy link
Member Author

Actually, the file updated is coming/jsonld.js. But it is to update JCS.

@davidlehn
Copy link
Contributor

Ah, I totally misread what was going on there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants