-
Notifications
You must be signed in to change notification settings - Fork 35
Updates to pass base URL #356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Term definition. For #265.
dlongley
approved these changes
Jan 28, 2020
pchampin
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Appart from the duplicate 'context' in the definition of "term definition", looks good.
Co-Authored-By: Dave Longley <[email protected]>
…e original documentUrl containing the top-most context. This is initialized in `expand()` and when a _local context_ is `null`.
Commit message should be "Update JCS", not "Update jsonld.js": |
Actually, the file updated is coming/jsonld.js. But it is to update JCS. |
Ah, I totally misread what was going on there. |
This was referenced Feb 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to Expansion, Context Processing and Create Term definition.
The change touches a lot of parts, and leaves a little hand waiving when a context has been previously loaded.
For #265.
Preview | Diff