Skip to content

Language tags #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 14, 2019
Merged

Language tags #168

merged 10 commits into from
Oct 14, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Oct 13, 2019 •
edited by pr-preview bot
Loading

  • Remove requirement to normalize language tags to lower case, but note testing considerations.
  • Notes about normalizing language tags, issuing warnings when not well-formed, and not considering case when using for term selection.
  • Add a test for term selection where case of language does not match.

For #167.

Preview | Diff

rubensworks
rubensworks suggested changes Oct 14, 2019
View reviewed changes
pchampin
pchampin approved these changes Oct 14, 2019
View reviewed changes
@gkellogg gkellogg merged commit 0ccf4b2 into master Oct 14, 2019
@gkellogg gkellogg deleted the language-tags branch October 14, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubensworks rubensworks rubensworks requested changes

@pchampin pchampin pchampin approved these changes

@dlongley dlongley Awaiting requested review from dlongley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkellogg @pchampin @rubensworks