Skip to content

Compact IRI expansion with prefix flag false #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2019

Conversation

gkellogg
Copy link
Member

@gkellogg gkellogg commented Jun 14, 2019

Update tests and Expand IRI to not consider terms where the prefix flag is false when considering Compact IRIs.

Fixes w3c/json-ld-wg#90 and fixes w3c/json-ld-wg#87.


Preview | Diff

@gkellogg gkellogg requested review from dlongley and pchampin June 14, 2019 21:26
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the test makes a little more sense with the proposed changes (i.e. the "tag" term definition in the context is there for a reason). But apart from that, that's good.

That's a very small change indeed. Cheer up @iherman 😉

Improve compaction example.

Co-Authored-By: Pierre-Antoine Champin <[email protected]>
@gkellogg gkellogg requested a review from iherman June 15, 2019 13:40
@gkellogg gkellogg merged commit 3c6b442 into master Jun 17, 2019
@gkellogg gkellogg deleted the restrict-prefix-expansion branch June 17, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants