Stop adding additional newline when reading from stdin #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fragment += chunk; | ||
| }); | ||
|
|
||
| input.on("end", () => { | ||
| if (fragment.slice(-1) === "\n") { | ||
| fragment = fragment.slice(0,-1) |
|
What use case are you in? |
|
Added the semicolon... sorry too much Go lately. The problem is that every time I save a file in vim using vim-autoformat an additional newline was being appended to the file. |
vvakame
added a commit
that referenced
this pull request
Jul 26, 2015
Stop adding additional newline when reading from stdin
|
@joshuarubin I see. thanks mate! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading from stdin, an extra newline character was always being appended to the input. This fixes that.