Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

fix(code): highlighted lines were not highlighted #37

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

Kocal
Copy link
Contributor

@Kocal Kocal commented Jan 8, 2020

In code block, highlighted lines (ex: when using yaml{4-6} to higlight lines 4 to 6) were not highlighted because it was black on black.

What do you think?

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:
before:
Sélection_999(506)

after:
Sélection_999(507)

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome 78.0.3904.108
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@billyyyyy3320
Copy link
Member

It might be copied from VP's default theme.

Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@billyyyyy3320 billyyyyy3320 merged commit 377be90 into vuepress:master Jan 8, 2020
@Kocal Kocal deleted the fix/code-highlight branch January 8, 2020 13:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants