Skip to content
This repository was archived by the owner on May 13, 2024. It is now read-only.

docs: add vuepress-theme-ic to project using list #67

Merged
merged 1 commit into from
Mar 30, 2020

Conversation

IKangXu
Copy link
Contributor

@IKangXu IKangXu commented Mar 27, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • [ √] Other, please describe:
    add: add vuepress-theme-ic to project using list

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [ √] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Copy link
Member

@billyyyyy3320 billyyyyy3320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your efforts in growing VuePress community. I'd like to add your theme to the list, but I can't find any usage or guide when I browsed the website and Readme of your theme.

@IKangXu
Copy link
Contributor Author

IKangXu commented Mar 30, 2020

@newsbielt703 the usage documentation has been added.

@billyyyyy3320 billyyyyy3320 changed the title add: add vuepress-theme-ic to project using list docs: add vuepress-theme-ic to project using list Mar 30, 2020
@billyyyyy3320
Copy link
Member

@IKangXu Hmm, I can't understand why users have to use yarn link. Hasn't this theme been published as an NPM module?

Imho, if you want others to use your theme, you have to make it more understandable, such as the configuration, you can have a look at the docs of other blog themes in this list.

Nevertheless, how to write a theme or an NPM module is totally flexible and is up to the author(you). I'll merge this PR. 👍

@billyyyyy3320 billyyyyy3320 merged commit 565632d into vuepress:master Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants