-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Doc FR] — All files — French Translation Done #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Bruno Lesieur <[email protected]>
We have create a new branch with an history commit clean without all our working step not useful for « archive ». If that is ok for you, this PR is ready for merge. |
ne t'en fait pas pour l'historique bordelique, on squash toujours les PR 🙂 |
# Conflicts: # docs/fr/mutations.md Signed-off-by: Bruno Lesieur <[email protected]>
@posva : I have just up-to-date documentation with last modifications from « testing.md ». This PR is OK for Merge! PS : we have add two forgotten « dot » in « testing.md » |
Signed-off-by: Bruno Lesieur <[email protected]>
Merci d'avoir précisé que c'était fini |
Signed-off-by: Bruno Lesieur <[email protected]>
Hi @posva, What I can do for allows this PR to be merged? |
@posva What is the status of this PR, can we merge this? |
I'll review it today along with the other fr pr
On Sat, 5 Aug 2017, 08:02 katashin, ***@***.***> wrote:
@posva <https://github.com/posva> What is the status of this PR, can we
merge this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#847 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAoicUJK8zxRQsI0jH7pWJwqVH5LDJ6Rks5sVAVZgaJpZM4OJHiI>
.
--
Eduardo San Martin Morote
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ktsn 👍
@posva 🙆 |
We are the Vue-FR team. We provide our review on Vuex translation part (with cross consistency from others Vue documentations).
French review:
Process:
en
directory because in ourworking
branch we use theen
directory to work. All futuren
modification at an already translated position will warns us with a conflict.:working/en
to:dev/fr
and we will provide some pull request each time a set of pages will be translated.