Skip to content

Use replace instead of push in init render #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 25, 2017
Merged

Use replace instead of push in init render #52

merged 1 commit into from
May 25, 2017

Conversation

mehwww
Copy link
Contributor

@mehwww mehwww commented Mar 15, 2017

#51

@mehwww mehwww mentioned this pull request Mar 15, 2017
Closed
@xiachaoxulu
Copy link

i think should give currentPath a init value 。 such as window.location.pathname

@xiachaoxulu
Copy link

i think more， when currentPath is undefined ,router should replace 。
because currentPath init value should be from server ， not from window.location.pathname。
window.location.pathname is unless

@yyx990803 yyx990803 merged commit 186e8ab into vuejs:master May 25, 2017
@yyx990803 yyx990803 mentioned this pull request May 25, 2017
Closed
@JounQin JounQin mentioned this pull request Sep 18, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mehwww @xiachaoxulu @yyx990803