support vuex 2.0 migration #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 👍 |
blake-newman
force-pushed
the
patch/support-vuex-2-migration
branch
from
b4c24c1 to
b19229d
Compare
|
Fixed peer dependency range |
| @@ -6,7 +6,7 @@ exports.sync = function (store, router) { | |||
| var currentPath | |||
|
|
|||
| // sync router on store change | |||
| store.watch( | |||
| store._vm.$watch( | |||
There was a problem hiding this comment.
vuex 2.0 will still have store.watch - let's keep using the public API.
There was a problem hiding this comment.
okay, so will only support rc2 onwards. Thats fair enough.
blake-newman
force-pushed
the
patch/support-vuex-2-migration
branch
from
b19229d to
9bc49d3
Compare
blake-newman
force-pushed
the
patch/support-vuex-2-migration
branch
from
9bc49d3 to
0d9bdbb
Compare
blake-newman
force-pushed
the
patch/support-vuex-2-migration
branch
from
0d9bdbb to
247e6a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.