feat: allow no v-pre on code blocks (#413) #415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulivz
force-pushed
the
master
branch
3 times, most recently
from
14d9013 to
c7c0cd9
Compare
ulivz
force-pushed
the
master
branch
5 times, most recently
from
c992e38 to
c2eaff3
Compare
ulivz
requested changes
Jul 27, 2018
There was a problem hiding this comment.
Thanks for the good job. there are some tweaks needed before approved:
-
Use
{no-v-pre}for now. -
Add test for it.
-
Disable highlighting for those languages whose interpolation expression would be interrupted by highlighting.
See: #413 (comment):
ulivz
force-pushed
the
master
branch
4 times, most recently
from
0c3bc3a to
cf1e6fc
Compare
|
@ulivz Modified. Further review wanted 😄 . |
ulivz
force-pushed
the
master
branch
2 times, most recently
from
bd69d41 to
903138e
Compare
ulivz
force-pushed
the
master
branch
2 times, most recently
from
3f79224 to
fb05066
Compare
|
Any updates this? Would love to be able to use this feature to get a centrally configurable domain name injected into many code blocks spread out over a semi-large documentation project. |
|
So many changes after the last commit of the PR. This feature is still to be determined. Maybe it will be finished in the next version. It's up to the maintainer. 😄 |
ulivz
force-pushed
the
master
branch
3 times, most recently
from
6c3127f to
71574f2
Compare
ulivz
force-pushed
the
master
branch
5 times, most recently
from
316e022 to
1284944
Compare
|
Closing since for now it can be addressed by a plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #413