-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat($core): Improve VuePress build time #2163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
9dce835
feat: Improve rendering process with page parallel rendering
kefranabg cbe1af0
feat: Run extendPageData functions in parallel
kefranabg 59b20bb
fix: Update Page.js tests
kefranabg 8522e27
:recycle: refactoring enhance method
kefranabg 169cc05
fix: fix tests
kefranabg 9d02c1c
Update packages/@vuepress/core/lib/node/Page.js
kefranabg fec099f
refactor: Code review update
kefranabg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -89,11 +89,13 @@ module.exports = class Build extends EventEmitter { | |||||||||
// render pages | ||||||||||
logger.wait('Rendering static HTML...') | ||||||||||
|
||||||||||
const pagePaths = [] | ||||||||||
const pagePathsPromises = [] | ||||||||||
for (const page of this.context.pages) { | ||||||||||
pagePaths.push(await this.renderPage(page)) | ||||||||||
pagePathsPromises.push(this.renderPage(page)) | ||||||||||
} | ||||||||||
|
||||||||||
const pagePaths = await Promise.all(pagePathsPromises) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. From 91 to 97:
Suggested change
|
||||||||||
|
||||||||||
readline.clearLine(process.stdout, 0) | ||||||||||
readline.cursorTo(process.stdout, 0) | ||||||||||
|
||||||||||
|
@@ -134,9 +136,6 @@ module.exports = class Build extends EventEmitter { | |||||||||
|
||||||||||
async renderPage (page) { | ||||||||||
const pagePath = decodeURIComponent(page.path) | ||||||||||
readline.clearLine(process.stdout, 0) | ||||||||||
readline.cursorTo(process.stdout, 0) | ||||||||||
process.stdout.write(`Rendering page: ${pagePath}`) | ||||||||||
|
||||||||||
// #565 Avoid duplicate description meta at SSR. | ||||||||||
const meta = (page.frontmatter && page.frontmatter.meta || []).filter(item => item.name !== 'description') | ||||||||||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.