Skip to content

docs: Update badge license link #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2019

Conversation

jamesgeorge007
Copy link
Contributor

Summary
Made the license badge point to the respective file.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:
N/A

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jamesgeorge007 !

@bencodezen bencodezen changed the title fix(docs): Minor tweak docs: Minor tweak Aug 28, 2019
@bencodezen
Copy link
Member

Hi @jamesgeorge007! It looks like everything is good to go, but the check for the Semantic Pull request is still pending. If you could make the necessary changes to ensure the PR passes the check, we will be able to merge it. Thanks!

made license badge point to the respective file
@kefranabg kefranabg changed the title docs: Minor tweak docs: Update badge license link Aug 28, 2019
@kefranabg kefranabg merged commit 6d47c9e into vuejs:master Aug 28, 2019
@vue-bot
Copy link

vue-bot commented Aug 28, 2019

Hey @jamesgeorge007, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

@jamesgeorge007 jamesgeorge007 deleted the feat/update-docs branch August 28, 2019 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants