Skip to content

chore(docs): update usage #1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

chore(docs): update usage #1764

wants to merge 2 commits into from

Conversation

danranVm
Copy link

@danranVm danranVm commented Aug 9, 2019

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@kefranabg
Copy link
Collaborator

Hi @danranVm,

Thanks for opening this PR.

This config head: [['link', { rel: 'manifest', href: '/manifest.json' }]], is not required if you want to use the PWA plugin.

However I noticed that an example of a fully PWA-compliant configuration was missing in the doc (and I think that's what you were looking for). I just opened a PR to do an update.

Closes this PR in favor of #1769

@kefranabg kefranabg closed this Aug 10, 2019
@danranVm danranVm deleted the docs branch August 11, 2019 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants