Empty build output directory instead of remove #1030
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What kind of change does this PR introduce? (check at least one)
If changing the UI of default theme, please provide the before/after screenshot:
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
This PR simply changes
fs.remove
during build/build.js
tofs.emptyDir
. This arose due to a semi-funky build system in which we are building the documentation via Docker container into a Docker volume which is also attached to an NGINX container which has the.vuepress/dist
folder mounted as a Volume and served via NGINX.fs.remove
attempts to unlink thedist
folder, causing a build failure due to the NGINX mount.emptyDir
simply empties the directory and does not delete it, and I couldn't obviously see a dependency on totally removing the.vuepress/dist
folder.Unfortunately there was a significant amount of test failures, but none that looked suspiciously due to this change:
Many due to:
Built and run in Docker:
fix #xxx[,#xxx]
, where "xxx" is the issue number)You have tested in the following browsers: (Providing a detailed version will be better.)
If adding a new feature, the PR's description includes:
To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.
Other information: