Skip to content

Deploy in Gitlab #2584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
loctran016 opened this issue Aug 24, 2020 · 2 comments
Closed

Deploy in Gitlab #2584

loctran016 opened this issue Aug 24, 2020 · 2 comments

Comments

@loctran016
Copy link

loctran016 commented Aug 24, 2020 •
edited
Loading

In your guide how to deploy vuepress on Gitlab, I have found that put these code in .gitlab-ci.yml may cause issue if you are using extension need node.js 10+ and it is recommend to use the node.js 10+ as well

image: node:9.11.1

pages:
  cache:
    paths:
    - node_modules/

  script:
  - yarn install # npm install
  - yarn docs:build # npm run docs:build
  artifacts:
    paths:
    - public
  only:
  - master

The image: node:9.11.1 mean that the gitlab-ci will use node.js 9.11.1 which may cause issue somehow. I don't know if you could update the guide, maybe change node:9.11.1 into node:14.8.0 or something newer than node.js 10. Thanks for reading my issue.
Although this maybe unnecessary, here is my project if you want that: https://gitlab.com/LocTran016/genetics
@bencodezen
Copy link
Member

@loctran016 This is a great suggestion! Would you like to open a PR to make this update? No worries if not!

@loctran016 loctran016 mentioned this issue Aug 31, 2020
Merged
18 tasks
bencodezen pushed a commit that referenced this issue Sep 1, 2020
docs: update node version for gitlab ci config (#2592)
4b4c1d5 
* Update deploy.md

Here is my issue: #2584
I've found that node:9.11.1 is too old and in the `Prerequisites` part of the guide, it's recommend to use node 10+ so update a small comment could be useful. I don't know if it is applicable to delete `node:9.11.1` and replace with `node:14.8.0` so I just add a comment

* Update deploy.md
@loctran016
Copy link
Author

Solved so close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bencodezen @loctran016