Skip to content

fix:#6938 #6942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/components/keep-alive.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export default {
const componentOptions: ?VNodeComponentOptions = vnode && vnode.componentOptions
if (componentOptions) {
// check pattern
const name: ?string = getComponentName(componentOptions)
if (name && (
const name: ?string = componentOptions && componentOptions.Ctor.options.name
if (!name || (
(this.exclude && matches(this.exclude, name)) ||
(this.include && !matches(this.include, name))
)) {
Expand Down
86 changes: 76 additions & 10 deletions test/unit/features/component/component-keep-alive.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ describe('Component keep-alive', () => {
let components, one, two, el
beforeEach(() => {
one = {
name:'one',
template: '<div>one</div>',
created: jasmine.createSpy('one created'),
mounted: jasmine.createSpy('one mounted'),
Expand All @@ -16,6 +17,7 @@ describe('Component keep-alive', () => {
destroyed: jasmine.createSpy('one destroyed')
}
two = {
name:'two',
template: '<div>two</div>',
created: jasmine.createSpy('two created'),
mounted: jasmine.createSpy('two mounted'),
Expand Down Expand Up @@ -448,32 +450,93 @@ describe('Component keep-alive', () => {
// #4237
it('should update latest props/listeners for a re-activated component', done => {
const one = {
props: ['prop'],
template: `<div>one {{ prop }}</div>`
name:'cache',
data(){
return{
random:Math.random(0,10)
}
},
template: `<div class="child">{{ random }}</div>`
}
const two = {
props: ['prop'],
template: `<div>two {{ prop }}</div>`
data(){
return{
random:Math.random(0,10)
}
},
template: `<div class="child">{{ random }}</div>`
}
const vm = new Vue({
data: { view: 'one', n: 1 },
data: { view: 'one'},
template: `
<div>
<keep-alive>
<component :is="view" :prop="n"></component>
<component :is="view" ></component>
</keep-alive>
</div>
`,
components: { one, two }
}).$mount()
let cacheText, noCacheText

expect(vm.$el.textContent).toBe('one 1')
vm.n++
cacheText = vm.$el.textContent
vm.view = 'two'
waitForUpdate(() => {
expect(vm.$el.textContent).toBe('one 2')
noCacheText = vm.$el.textContent
vm.view = 'one'
}).then(() => {
expect(vm.$el.textContent).toBe(cacheText)
vm.view = 'two'
}).then(() => {
expect(vm.$el.textContent).not.toBe(noCacheText)
}).then(done)
})
it('wsgwsgwsgwsgwsgwsgwsgwsgwsgwsgwsgwsgwsgwsgwsgwsg', done => {
const one = {
name:'cache',
data(){
return{
random:Math.random(0,10)
}
},
template: `<div class="child">{{ random }}</div>`
}
const two = {
data(){
return{
random:Math.random(0,10)
}
},
template: `<div class="child">{{ random }}</div>`
}
const vm = new Vue({
data: { view: 'one'},
template: `
<div>
<keep-alive>
<component :is="view" ></component>
</keep-alive>
</div>
`,
components: { one, two }
}).$mount()


let cacheText, noCacheText

waitForUpdate(() => {
cacheText = vm.$el.textContent
vm.view = 'two'
}).then(() => {

noCacheText = vm.$el.textContent
expect(noCacheText).not.toBe(cacheText)
vm.view = 'one'
}).then(() => {
expect(vm.$el.textContent).toBe(cacheText)
vm.view = 'two'
}).then(() => {
expect(vm.$el.textContent).toBe('two 2')
expect(vm.$el.textContent).not.toBe(noCacheText)
}).then(done)
})

Expand Down Expand Up @@ -977,16 +1040,19 @@ describe('Component keep-alive', () => {
},
components: {
aa: {
name:'aa',
template: '<div>a</div>',
created: spyA,
destroyed: spyAD
},
bb: {
name:'bb',
template: '<div>bbb</div>',
created: spyB,
destroyed: spyBD
},
cc: {
name:'cc',
template: '<div>ccc</div>',
created: spyC,
destroyed: spyCD
Expand Down