Skip to content

build: install dependency for vue-server-renderer in setup script #6839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

jkzing
Copy link
Member

@jkzing jkzing commented Oct 18, 2017

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Currently when running npm test, an error occurs:

packages/vue-server-renderer/types/index.d.ts(1,44): error TS2307: Cannot find module 'vue'.

It's because that vue-server-renderer dependencies are missing, simply run npm install under packages/vue-server-renderer could solve that.

This PR is trying to improve setup script so that new contributor can run npm test successfully.

@yyx990803 yyx990803 merged commit a433b16 into vuejs:dev Oct 18, 2017
@HerringtonDarkholme
Copy link
Member

This can be solved by one simple tsconfig.json, so we can get simpler build script and fewer deps. (I wonder how CI works because I also encounter this locally. @ktsn )

waht's your opinion? @yyx990803 @jkzing

@yyx990803
Copy link
Member

If there's an easier way to deal with this, yes please!

@jkzing
Copy link
Member Author

jkzing commented Oct 20, 2017

@HerringtonDarkholme It would be much better if we can skip npm install, I just didn't figure out how to do it...😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants