-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
Warn when a inject has been not provided #5681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0f9fceb
warn when a inject has been not provided
maciej-ka 8e28a3e
typo
maciej-ka 4cdb589
typo
maciej-ka 30afa7a
fix when undefined is provided
maciej-ka f229397
use util hasOwn
maciej-ka 29f265d
refactor
maciej-ka 08f0a8b
test case
maciej-ka 0b2e89c
Revert "test case"
maciej-ka 5f3ccc9
test case
maciej-ka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,6 +3,7 @@ | |
import { hasSymbol } from 'core/util/env' | ||
import { warn } from '../util/index' | ||
import { defineReactive } from '../observer/index' | ||
import { hasOwn } from '../../shared/util' | ||
|
||
export function initProvide (vm: Component) { | ||
const provide = vm.$options.provide | ||
|
@@ -57,6 +58,8 @@ export function resolveInject (inject: any, vm: Component): ?Object { | |
} | ||
source = source.$parent | ||
} | ||
process.env.NODE_ENV !== 'production' && !hasOwn(result, key) && | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's use |
||
warn(`Injection "${key}" not found`, vm) | ||
} | ||
return result | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can just use
shared/util
instead because it's aliased