Skip to content

Add picture to the isHTMLTag map so it suppresses unneeded warnings while unit testing #5675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2017

Conversation

timbenniks
Copy link
Contributor

@timbenniks timbenniks commented May 15, 2017

This change will make sure the below error is not seen while unit testing components using picture in their template: [Vue warn]: Unknown custom element: picture - did you register the component correctly? For recursive components, make sure to provide the "name" option.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe: suppresses unneeded warning while unit testing

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

This change will make sure the below error is not seen while unit testing components using <picture> in their template.
[Vue warn]: Unknown custom element: <picture> - did you register the component correctly? For recursive components, make sure to provide the "name" option.
@yyx990803 yyx990803 merged commit 3cda98a into vuejs:dev May 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants