Warn when not passing props in kebab-case #5161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyx990803
requested changes
Mar 10, 2017
src/core/vdom/create-component.js
Outdated
| @@ -287,6 +287,17 @@ function extractProps (data: VNodeData, Ctor: Class<Component>): ?Object { | |||
| if (attrs || props || domProps) { | |||
| for (const key in propOptions) { | |||
| const altKey = hyphenate(key) | |||
| const keyInLowerCase = key.toLowerCase() | |||
There was a problem hiding this comment.
Can we move this inside the NODE_ENV conditional block as well? It's ok to use two nested ifs.
awamwang
added a commit
to awamwang/vue
that referenced
this pull request
Mar 16, 2017
* 'dev' of https://github.com/vuejs/vue: (118 commits) [weex] Support unary and left open tags (vuejs#5052) [release] 2.2.4 [build] 2.2.4 fix perf measure regression for nested components of the same name (fix vuejs#5181) [release] 2.2.3 [build] 2.2.3 perf code coverage improve camelCase prop warning message warn when template contains text outside root element (vuejs#5164) Warn when not passing props in kebab-case (vuejs#5161) turn off perf timeline measuring by default + reduce its impact on dev time perf (fix vuejs#5174) v-bind object should have lower priority than explicit bindings (fix vuejs#5150) fix custom directive arg fall through (fix vuejs#5162) formatting tweaks refactor create-component fix wrong order of generate modifier code (vuejs#5147) fix v-on unit test (vuejs#5144) fix vuejs#5121: parse content in textarea as plaintext (vuejs#5143) [release] 2.2.2 [build] 2.2.2 ... # Conflicts: # dist/vue.runtime.common.js # src/core/vdom/helpers/update-listeners.js
|
What release should get this on board (2.2.6 seems to don't have it)? |
|
@yamsellem Already released in v2.2.3 |
|
@CodinCat sorry 'bout that. Webpack was lower casing our html attributes ( |
|
If you are using single file components then it's not a problem. camelCased props will be converted to kebab-case automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Hi,
Please see #5145
This patch adds a warning when user is not passing props in kebab-case mistakenly, for example:
I know this is stated on the guide, but since it's a very common mistake (based on the questions on stackoverflow (see the issue above) and the forum), I think it is worth to add a warning and I believe this will save a lot of people's debugging time and provide a more friendly development experience.
And for the performance, this is not a complex algorithm. It only adds a fews operations (both
toLowerCaseandhasOwnPropertyare fast enough) in O(n) so I would say the impact on performance is negligible (almost no impact when running unit test on my machine).thanks!