fine-tuning of toNumber function #4684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mingmingwon
commented
Jan 10, 2017
mingmingwon
commented
- parseFloat() support only one param, see MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseFloat
- maybe it's better to use isNaN() to judge the conversion result?
1. parseFloat() support only one param, see MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/parseFloat 2. maybe it's better to use isNaN() to judge the conversion result?
znck
reviewed
Jan 10, 2017
| const n = parseFloat(val, 10) | ||
| return (n || n === 0) ? n : val | ||
| const n = parseFloat(val) | ||
| return isNaN(n) ? val : n |
There was a problem hiding this comment.
With regex
if(/^(\-|\+)?([0-9]+(\.[0-9]+)?|Infinity)$/.test(val))
return Number(val);
return val;There was a problem hiding this comment.
regex is also good…
There was a problem hiding this comment.
I don't think using a regex is a good idea. parseFloat seems to be the fastest way to convert a string to a number: https://jsperf.com/number-vs-plus-vs-parsefloat
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.