Add an ES5/IE compatible version of wrapper to distribution

[ChristianMurphy]

resolves #31

[jgribonvald]

+1 to have a solution for IE11

[pablocattaneo]

+1 to have a solution for IE11

[wbern]

If this means this wrapper can support IE 10, it would mean a lot.

[ChristianMurphy]

@wbern see #31 (comment)

[wbern]

@ChristianMurphy we are using that wrapper today for the IE legacy support it offers, but the support for templates and slots is really just not there (likely because no shadow dom) and the vue devtools extension fails to show components below the first level on pages that use it.

That's why I want to switch to this implementation.

[ChristianMurphy]

@wbern in theory this should work back to IE9, I've only done testing with IE11.

[wbern]

@ChristianMurphy in our case we need to support IE 10. I wonder if that could be targeted for this repo?

I did some attempts with this wrapper and it didn't really work when I tried adding the wc polyfills. But I'll try again someday.

[ChristianMurphy]

@wbern it could, and in theory it already does.
For IE 10 it probably needs core js and webcomponent js polyfills

[cdeng-amplify]

How would this work when making web components via the vue cli with the --target as wc? Is this based off the target browserlist whether to use es6 vs es5 version of the web component wrapper?

[ChristianMurphy]

My thought is to support something like modern mode for target web component.
Where an ES6+unpolyfilled web component version and a separate ES5+polyfilled version would be generated.

[cdeng-amplify]

@ChristianMurphy, the modern mode for target web component is ignored.

Modern mode only works with default target (app). For libraries or web components, use the browserslist config to specify target browsers.

Either way, when do you think this will be integrated to to the main branch? Thank you!

[ChristianMurphy]

the modern mode for target web component is ignored

I'm aware, that's why I'm suggesting adding it 🙂

Either way, when do you think this will be integrated to to the main branch?

If/when this will be merged is a question @yyx990803 would be able to answer.

[cdeng-amplify]

@ChristianMurphy Okay, thank you. perhaps we can add a transpilation step to convert the output file to es5 version with webpack for now.

[karol-f]

Guys, this PR is not getting attention from @yyx990803, either:

• he don't want to support browsers, without ES2015 class support
• he don't get mentions from this repo

You can try to get him on e.g. twitter (https://twitter.com/youyuxi) and politely ask for an attention.

[yyx990803]

As stated in README:

(For non-ES2015 support) You might want to reconsider since you'll be better off not using Web Components in this case.

So it's correct that I do not want to support non-ever green browsers (and all associated problems that come with it). You are welcome to fork it as a separate distribution though.

[ChristianMurphy]

So it's correct that I do not want to support non-ever green browsers (and all associated problems that come with it). You are welcome to fork it as a separate distribution though.

Fair enough, thanks for the review!

---

@wbern There is a work around in #31 (comment).
It may be worth opening an issue upstream to see if transpileDependencies can be fixed so it can be applied to any dependency, including vue-web-component-wrapper. #31 (comment).

[wbern]

@ChristianMurphy I'm working for a company and it was somewhat disappointing to see this rejection. Since I don't see any larger issues a minor PR like this being able to take future changes from upstream, it's possible there might be a fork of this repo.

[egucciar]

we have a fork in use right now, but we're also strapped on resources and not able to really maintain our public repos during this timeframe. So feel free to take a look but be warned we will probably not be able to provide assistance , help or anything like that.

https://github.com/Updater/vue-web-component-wrapper

[VelenAranha]

@ChristianMurphy Is there any reason why docs still say mention that Web Component mode does not support IE11 and below?

[ChristianMurphy]

Yes, because this wasn't merged, and IE11 isn't supported out of the box.
See the other comment in this PR and in #31 for alternatives and work arounds.

[wbern]

@VelenAranha @ChristianMurphy I think my fork is worth checking out, it has at least 1 critical fix for IE11. #79