Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@LinusBorg
I'm sorry to mention you suddenly.
I want use
vue-web-component-wrapper
for Vue3 so I opened this draft PR.I'm aware that @LinusBorg started working on this porting (#93#issuecomment-751347772) and this task is a bit lower priority (93#issuecomment-778991647) .
I understand it takes time to develop some great features, but I want you to provided
wrap()
for v3 providing the same functions as the current one first. So, I opened this.This PR is draft so
wrap()
for v3 is not implemented yet. After @LinusBorg accept this PR's policy, I'll resume to work on remaining tasks.Summary of fixes
src/index.js
. The filename is different only.vue-cli
depends onvue-web-component-wrapper
so it will take time before it can be used with vue-cli if I change api spec.wrap()
in new entry function (src/index.ts
) has the same parameters as the current entry function.wrapV2()
andwrapV3()
according toVue.version
.Files
src/index.ts
andsrc/wrapV3.ts
is written by TypeScript and rollup plugin transpiles them.dist/index.d.ts
)test/fixtures/*.html
load transpilede code.