Skip to content

docs: update docs/ja #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 7, 2018
Merged

docs: update docs/ja #900

merged 2 commits into from
Aug 7, 2018

Conversation

38elements
Copy link
Contributor

No description provided.

kazupon
kazupon suggested changes Aug 4, 2018
View reviewed changes
Copy link
Member

@kazupon kazupon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー 👀 コメント 💬 しました。
よろしくお願いします！

docs/ja/guides/using-with-typescript.md Outdated
最初にプロジェクトを作成します。もし、Vue CLI をインストールしていないなら、 Vue CLI をグローバルにインストールしてください。

```shell
$ npm install -g @vue/cli-service-global
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm install -g @vue/cli では？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原文もそうなんですね。https://github.com/vuejs/vue-test-utils/blob/dev/docs/guides/using-with-typescript.md#adding-typescript

docs/ja/guides/using-with-typescript.md Outdated
}
```

### Jest での SFCs の処理
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vue で単体テスト出来る人は、初心者じゃないので、SFCsでも通じると思うんですが、ここは、単一ファイルコンポーネントでなるべく訳した方がいいと思います。

38elements
38elements commented Aug 4, 2018
View reviewed changes
docs/guides/using-with-typescript.md
@@ -11,7 +11,7 @@ In this guide, we'll walk through how to setup a testing setup for a TypeScript
First you need to create a project. If you don't have Vue CLI installed, install it globally:

```shell
$ npm install -g @vue/cli-service-global
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyerburgh @kazupon
This line was changed.

@38elements
Copy link
Contributor Author

@kazupon
レビューありがとうございます。
指摘していただいた箇所を修正しました。
よろしくお願いします。

@kazupon
Copy link
Member

kazupon commented Aug 5, 2018

@38elements
👍

@kazupon
Copy link
Member

kazupon commented Aug 7, 2018

@eddyerburgh
You can merge this PR. 🙂

eddyerburgh
eddyerburgh approved these changes Aug 7, 2018
View reviewed changes
Copy link
Member

@eddyerburgh eddyerburgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys :)

@eddyerburgh eddyerburgh merged commit 3d47913 into vuejs:dev Aug 7, 2018
@38elements 38elements deleted the document branch August 26, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazupon kazupon kazupon requested changes

@eddyerburgh eddyerburgh eddyerburgh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@38elements @kazupon @eddyerburgh