WIP: Add parent in create-instance #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@38elements One of the issues with this PR is that it's impossible to add this functionality—https://github.com/vuejs/vue-test-utils/blob/dev/test/specs/mounting-options/slots.spec.js#L107, where the slot is rendered using the context of the component that is mounted. On reflection, I don't think we should have this behavior, since slots do not behave like this in Vue. What do you think? |
|
Since the behavior is a rare use case and rarely used to write specifications, |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve a few issues. It should make scopedSlots and slots easier to implement
Problems:
$mountto create a nested component instance, which is incompatible with server-test-utilsFixes #472