-
Notifications
You must be signed in to change notification settings - Fork 668
feat: Add setValue method #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
b600bbc
a955dec
241e772
5e243ca
37150d5
4fddcd1
2e91724
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -531,6 +531,81 @@ export default class Wrapper implements BaseWrapper { | |
this.vnode = this.vm._vnode | ||
} | ||
|
||
/** | ||
* Sets element value and triggers input event | ||
*/ | ||
setValue (value: any) { | ||
const el = this.element | ||
|
||
if (!el) { | ||
throwError('cannot call wrapper.setValue() on a wrapper without an element') | ||
} | ||
|
||
const tag = el.tagName | ||
const type = this.attributes().type | ||
const event = 'input' | ||
|
||
if (this.isVueComponent) { | ||
} else if (tag === 'SELECT') { | ||
// event = 'change' | ||
// el.value = value | ||
throwError('wrapper.setValue() cannot be called on select') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You can tell the user to call setSelected(). Also, can you change the errors to this format:
|
||
} else if (tag === 'INPUT' && type === 'checkbox') { | ||
throwError('wrapper.setValue() cannot be called on checkbox. Use wrapper.setChecked() instead') | ||
} else if (tag === 'INPUT' && type === 'radio') { | ||
throwError('wrapper.setValue() cannot be called on radio. Use wrapper.setChecked() instead') | ||
} else if (tag === 'INPUT' || tag === 'textarea') { | ||
} else { | ||
throwError('wrapper.setValue() cannot be called on this element') | ||
} | ||
|
||
el.value = value | ||
this.trigger(event) | ||
} | ||
|
||
/** | ||
* Checks radio button or checkbox element | ||
*/ | ||
setChecked (checked: boolean) { | ||
console.log(typeof checked) | ||
if (typeof checked !== 'undefined') { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should default to true, so you can call setChecked() and it will set the element to checked. What do you think? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is set to true if no argument is passed. It isn't set on the parameters as a default but it behaves the way you suggest, there is a test for this specific case. |
||
if (typeof checked !== 'boolean') { | ||
throwError('wrapper.setChecked() must be passed a boolean') | ||
} | ||
} else { | ||
checked = true | ||
} | ||
|
||
const el = this.element | ||
|
||
if (!el) { | ||
throwError('cannot call wrapper.setChecked() on a wrapper without an element') | ||
} | ||
|
||
const tag = el.tagName | ||
const type = this.attributes().type | ||
const event = 'change' | ||
|
||
if (this.isVueComponent) { | ||
throwError('wrapper.setChecked() cannot be called on component. Use wrapper.setValue() instead') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A component instance still has a root element, which can have its value set, so I think we should let setChecked work for vue instance wrappers There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. My concern is related to how v-model behaves on components, but Im not sure. Let me know your final decision There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The v-model would be set on the root element, so if you have a component like this: <template>
<input type="text" />
</template> And you called
All component instance wrappers have a root element (this.element) so you can keep the current code and it would work correctly on instance wrappers. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you remove this check for isVueComponent |
||
} else if (tag === 'SELECT') { | ||
throwError('wrapper.setChecked() cannot be called on select') | ||
} else if (tag === 'INPUT' && type === 'checkbox') { | ||
el.checked = checked | ||
this.trigger(event) | ||
} else if (tag === 'INPUT' && type === 'radio') { | ||
if (!checked) { | ||
throwError('wrapper.setChecked() cannot be called with parameter false on radio') | ||
} | ||
el.checked = true | ||
this.trigger(event) | ||
} else if (tag === 'INPUT' || tag === 'textarea') { | ||
throwError('wrapper.setChecked() cannot be called on "text" inputs. Use wrapper.setValue() instead') | ||
} else { | ||
throwError('wrapper.setChecked() cannot be called on this element') | ||
} | ||
} | ||
|
||
/** | ||
* Return text of wrapper element | ||
*/ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
<template> | ||
<div> | ||
<input type="checkbox" v-model="checkboxVal"> | ||
<input type="radio" v-model="radioVal" id="radioFoo" value="radioFooResult"> | ||
<input type="radio" v-model="radioVal" id="radioBar" value="radioBarResult"> | ||
<input type="text" v-model="textVal"> | ||
<select v-model="selectVal"> | ||
<option value="selectA"></option> | ||
<option value="selectB"></option> | ||
<option value="selectC"></option> | ||
</select> | ||
<label id="label-el"></label> | ||
|
||
<span class="checkboxResult" v-if="checkboxVal">checkbox checked</span> | ||
{{ textVal }} | ||
{{ selectVal }} | ||
{{ radioVal }} | ||
</div> | ||
</template> | ||
|
||
<script> | ||
export default { | ||
name: 'component-with-input', | ||
data () { | ||
return { | ||
checkboxVal: undefined, | ||
textVal: undefined, | ||
radioVal: undefined, | ||
selectVal: undefined | ||
} | ||
} | ||
} | ||
</script> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,98 @@ | ||
import ComponentWithInput from '~resources/components/component-with-input.vue' | ||
import { describeWithShallowAndMount } from '~resources/utils' | ||
|
||
describeWithShallowAndMount('setChecked', (mountingMethod) => { | ||
it('sets element checked true with no option passed', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
input.setChecked() | ||
|
||
expect(input.element.checked).to.equal(true) | ||
}) | ||
|
||
it('sets element checked equal to param passed', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
|
||
input.setChecked(true) | ||
expect(input.element.checked).to.equal(true) | ||
|
||
input.setChecked(false) | ||
expect(input.element.checked).to.equal(false) | ||
}) | ||
|
||
it('calls trigger with change event', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
sinon.spy(input, 'trigger') | ||
|
||
input.setChecked() | ||
|
||
expect(input.trigger.called).to.equal(true) | ||
expect(input.trigger.args[0][0]).to.equal('change') | ||
}) | ||
|
||
it('updates dom with checkbox v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="checkbox"]') | ||
|
||
input.setChecked() | ||
expect(wrapper.text()).to.contain('checkbox checked') | ||
|
||
input.setChecked(false) | ||
expect(wrapper.text()).to.not.contain('checkbox checked') | ||
}) | ||
|
||
it('updates dom with radio v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
|
||
wrapper.find('#radioBar').setChecked() | ||
expect(wrapper.text()).to.contain('radioBarResult') | ||
|
||
wrapper.find('#radioFoo').setChecked() | ||
expect(wrapper.text()).to.contain('radioFooResult') | ||
}) | ||
|
||
it('throws error if checked param is not boolean', () => { | ||
const message = 'wrapper.setChecked() must be passed a boolean' | ||
shouldThrowErrorOnElement('input[type="checkbox"]', message, 'asd') | ||
}) | ||
|
||
it('throws error if checked param is false on radio element', () => { | ||
const message = 'wrapper.setChecked() cannot be called with parameter false on radio' | ||
shouldThrowErrorOnElement('#radioFoo', message, false) | ||
}) | ||
|
||
it('throws error if wrapper does not contain element', () => { | ||
const wrapper = mountingMethod({ render: (h) => h('div') }) | ||
const div = wrapper.find('div') | ||
div.element = null | ||
|
||
const fn = () => div.setChecked() | ||
const message = '[vue-test-utils]: cannot call wrapper.setChecked() on a wrapper without an element' | ||
expect(fn).to.throw().with.property('message', message) | ||
}) | ||
|
||
it('throws error if element is select', () => { | ||
const message = 'wrapper.setChecked() cannot be called on select' | ||
shouldThrowErrorOnElement('select', message) | ||
}) | ||
|
||
it('throws error if element is text like', () => { | ||
const message = 'wrapper.setChecked() cannot be called on "text" inputs. Use wrapper.setValue() instead' | ||
shouldThrowErrorOnElement('input[type="text"]', message) | ||
}) | ||
|
||
it('throws error if element is not valid', () => { | ||
const message = 'wrapper.setChecked() cannot be called on this element' | ||
shouldThrowErrorOnElement('#label-el', message) | ||
}) | ||
|
||
function shouldThrowErrorOnElement (selector, message, value) { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find(selector) | ||
|
||
const fn = () => input.setChecked(value) | ||
expect(fn).to.throw().with.property('message', '[vue-test-utils]: ' + message) | ||
} | ||
}) |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
import ComponentWithInput from '~resources/components/component-with-input.vue' | ||
import { describeWithShallowAndMount } from '~resources/utils' | ||
|
||
describeWithShallowAndMount('setValue', (mountingMethod) => { | ||
it('sets element value', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="text"]') | ||
input.setValue('foo') | ||
|
||
expect(input.element.value).to.equal('foo') | ||
}) | ||
|
||
it('calls trigger with input event', () => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can remove this test, as long as the dom updates with the v-model, it doesn't matter whether we call trigger or dispatch an event directly. |
||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="text"]') | ||
sinon.spy(input, 'trigger') | ||
|
||
input.setValue('foo') | ||
|
||
expect(input.trigger.called).to.equal(true) | ||
expect(input.trigger.args[0][0]).to.equal('input') | ||
}) | ||
|
||
it('updates dom with v-model', () => { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find('input[type="text"]') | ||
|
||
input.setValue('input text awesome binding') | ||
|
||
expect(wrapper.text()).to.contain('input text awesome binding') | ||
}) | ||
|
||
it('throws error if wrapper does not contain element', () => { | ||
const wrapper = mountingMethod({ render: (h) => h('div') }) | ||
const div = wrapper.find('div') | ||
div.element = null | ||
const fn = () => div.setValue('') | ||
const message = '[vue-test-utils]: cannot call wrapper.setValue() on a wrapper without an element' | ||
expect(fn).to.throw().with.property('message', message) | ||
}) | ||
|
||
it('throws error if element is select', () => { | ||
const message = 'wrapper.setValue() cannot be called on select' | ||
shouldThrowErrorOnElement('select', message) | ||
}) | ||
|
||
it('throws error if element is radio', () => { | ||
const message = 'wrapper.setValue() cannot be called on radio. Use wrapper.setChecked() instead' | ||
shouldThrowErrorOnElement('input[type="radio"]', message) | ||
}) | ||
|
||
it('throws error if element is checkbox', () => { | ||
const message = 'wrapper.setValue() cannot be called on checkbox. Use wrapper.setChecked() instead' | ||
shouldThrowErrorOnElement('input[type="checkbox"]', message) | ||
}) | ||
|
||
it('throws error if element is not valid', () => { | ||
const message = 'wrapper.setValue() cannot be called on this element' | ||
shouldThrowErrorOnElement('#label-el', message) | ||
}) | ||
|
||
function shouldThrowErrorOnElement (selector, message) { | ||
const wrapper = mountingMethod(ComponentWithInput) | ||
const input = wrapper.find(selector) | ||
|
||
const fn = () => input.setValue('') | ||
expect(fn).to.throw().with.property('message', '[vue-test-utils]: ' + message) | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this check here? I don't think the function needs to behave differently if the wrapper contains a vue instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its unnecesary, will remove