Skip to content

fix: remove circular dependency checks #553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

eddyerburgh
Copy link
Member

The checks currently fail for lots of edge cases:

stubs: {
  UnreadState: '<div data-stub-unread-state v-bind="$props"><slot/></div>',
  UnreadState: '<div>unread-state</div>',
}

This removes checks for circular dependencies when using the stubs option. This was simple error handling, but I believe the logic to implement it effectively is substantial. For the moment, we should remove the check

@eddyerburgh eddyerburgh merged commit 093f521 into vuejs:dev Apr 23, 2018
@Akryum
Copy link
Member

Akryum commented Apr 24, 2018

@eddyerburgh I'm not sure the PR removes the checks in the code itself (you seem to only have changed the tests).

@eddyerburgh
Copy link
Member Author

Ah sorry, I was in a rush.

This has been removed in another PR, but it won't be released for another week or so (until beta.16).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants