Skip to content

fix classes() for svg elements #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 27, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/wrappers/wrapper.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,9 @@ export default class Wrapper implements BaseWrapper {
* Returns an Array containing all the classes on the element
*/
classes (): Array<string> {
let classes = this.element.className ? this.element.className.split(' ') : []
// works for HTML Element and SVG Element
const className = this.element.getAttribute('class')
let classes = className ? className.split(' ') : []
// Handle converting cssmodules identifiers back to the original class name
if (this.vm && this.vm.$style) {
const cssModuleIdentifiers = {}
Expand Down
8 changes: 8 additions & 0 deletions test/specs/wrapper/classes.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,12 @@ describeWithShallowAndMount('classes', (mountingMethod) => {
const wrapper = mountingMethod(ComponentWithCssModules)
expect(wrapper.classes()).to.eql(['extension', 'color-red'])
})

it('returns array of class names for svg element', () => {
const compiled = compileToFunctions('<svg class="a-class b-class"><text class="c-class"/></svg>')
const wrapper = mountingMethod(compiled)
expect(wrapper.classes()).to.contain('a-class')
expect(wrapper.classes()).to.contain('b-class')
expect(wrapper.find('text').classes()).to.contain('c-class')
})
})