Skip to content

Fix: add-attrs and add-listeners correctly restore silent config option #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Feb 13, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/add-attrs.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import Vue from 'vue'

export default function addAttrs (vm, attrs) {
const originalVueConfig = Vue.config
const originalSilent = Vue.config.silent
Vue.config.silent = true
if (attrs) {
vm.$attrs = attrs
} else {
vm.$attrs = {}
}
Vue.config.silent = originalVueConfig.silent
Vue.config.silent = originalSilent
}
4 changes: 2 additions & 2 deletions src/lib/add-listeners.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import Vue from 'vue'

export default function addListeners (vm, listeners) {
const originalVueConfig = Vue.config
const originalSilent = Vue.config.silent
Vue.config.silent = true
if (listeners) {
vm.$listeners = listeners
} else {
vm.$listeners = {}
}
Vue.config.silent = originalVueConfig.silent
Vue.config.silent = originalSilent
}
10 changes: 10 additions & 0 deletions test/specs/add-attrs.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import Vue from 'vue'
import addAttrs from '~src/lib/add-attrs'

describe('add-attrs', () => {
it('restores silent config value to original value', () => {
Vue.config.silent = false
addAttrs({}, {})
expect(Vue.config.silent).to.be.false
})
})
10 changes: 10 additions & 0 deletions test/specs/add-listeners.spec.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import Vue from 'vue'
import addListeners from '~src/lib/add-listeners'

describe('add-listeners', () => {
it('restores silent config value to original value', () => {
Vue.config.silent = false
addListeners({}, {})
expect(Vue.config.silent).to.be.false
})
})