Skip to content

refactor: rename visible to isVisible #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2018
Merged

refactor: rename visible to isVisible #425

merged 1 commit into from
Feb 11, 2018

Conversation

eddyerburgh
Copy link
Member

breaking change

@eddyerburgh eddyerburgh merged commit 3cffbab into vuejs:dev Feb 11, 2018
@eddyerburgh eddyerburgh deleted the refactor-visible-to-is-visible branch February 11, 2018 10:59
@gustav-vidispine
Copy link

gustav-vidispine commented Feb 19, 2018 •
edited
Loading

This not been released yet I assume? The docs says isVisible, but maybe should be visible() until the next release? TypeError: wrapper.find(...).isVisible is not a function threw me off until I found this issue :)

@eddyerburgh
Copy link
Member Author

Ah sorry, I'll release beta.12 tonight :)

@38elements 38elements mentioned this pull request Feb 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyerburgh @gustav-vidispine