feat: add generic for wrapper.find() and wrapper.get() #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
approved these changes
Jul 12, 2021
|
By defaulting to |
alecgibson
added a commit
to reedsy/vue-test-utils
that referenced
this pull request
Jul 23, 2021
The type definitions were updated to allow generic element typing in vuejs#1871 However, this "loosened" the default type from `HTMLElement` to `Element. This was actually a breaking change. For example, consumers may have had this test code: ```ts wrapper.element.click() ``` But `click()` only exists on `HTMLElement`, not on `Element`, so test compilation fails. This change moves the default type back to `HTMLElement`. If we want to loosen this requirement in the future, it should be considered a breaking change.
13 tasks
alecgibson
added a commit
to reedsy/vue-test-utils
that referenced
this pull request
Jul 23, 2021
The type definitions were updated to allow generic element typing in vuejs#1871 However, this "loosened" the default type from `HTMLElement` to `Element. This was actually a breaking change. For example, consumers may have had this test code: ```ts wrapper.element.click() ``` But `click()` only exists on `HTMLElement`, not on `Element`, so test compilation fails. This change moves the default type back to `HTMLElement`. If we want to loosen this requirement in the future, it should be considered a breaking change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.fix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
fix: #1870
This feature will allow to target already the need type of the Element e.g. SVGElement, HTMLElement or other
Example: