Skip to content

Update contains.md #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Update contains.md #1831

merged 1 commit into from
Apr 21, 2021

Conversation

maurer2
Copy link
Contributor

@maurer2 maurer2 commented Apr 21, 2021

Hello, it seems that all the other methods of wrapper-array are h2s while contains is an h3 and therefore doesn't show up in the sidebar menu.
Example: https://vue-test-utils.vuejs.org/api/wrapper-array/#exists
Afterwards the deprecation message from wrapper.contains could be added here as well in a subsequent pr.

Cheers

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Hello, all the other properties are h2 while contains is an h3 and therefore doesn't show up in the sidebar.

Cheers
@afontcu
Copy link
Member

afontcu commented Apr 21, 2021

nice catch, thanks!

@afontcu afontcu merged commit 7413b37 into vuejs:dev Apr 21, 2021
@maurer2
Copy link
Contributor Author

maurer2 commented Apr 21, 2021

Great. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants