docs(jest): clarify babel configuration #1730
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I copy pasted the original snippet to my `babel.config.json`.
```json
{
"babel": {
"presets": ["@babel/preset-env"]
}
}
```
I was wondering why I was getting a weird error: `Unknown option: .babel. Check out https://babeljs.io/docs/en/babel-core/#options for more information abou
t options.`
I spent 10 minutes googling `.babel`, until I realized that I'm an idiot and the snippet was only applicable to `package.json`. As someone not yet intimately familiar with babel, I'm hoping this change would help clarify the distinction between `package.json` and `babel.config.json`.
|
Can you try rebasing and running CI again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I copy pasted the original snippet to my
babel.config.json.{ "babel": { "presets": ["@babel/preset-env"] } }I was wondering why I was getting a weird error:
Unknown option: .babel. Check out https://babeljs.io/docs/en/babel-core/#options for more information abou t options.I spent 10 minutes googling
.babel, until I realized that I'm an idiot and the snippet was only applicable topackage.json. As someone not yet intimately familiar with babel, I'm hoping this change would help clarify the distinction betweenpackage.jsonandbabel.config.json.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch.When resolving a specific issue, it's referenced in the PR's title (e.g.fix #xxx[,#xxx], where "xxx" is the issue number)All tests are passing: https://github.com/vuejs/vue-test-utils/blob/dev/.github/CONTRIBUTING.md#development-setupNew/updated tests are includedIf adding a new feature, the PR's description includes:
A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)Other information:
This is a documentation update to differentiate
package.jsonfrombabel.config.json