Skip to content

feat: remove deprecation when is is called with component definition #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2020

Conversation

xanf
Copy link
Contributor

@xanf xanf commented Sep 1, 2020

See #1532 for discussion

This PR removes deprecation warnings when is is called against component definition:

// generates warning
expect(wrapper.is('div')).toBe(true);
// does not generate warning
expect(wrapper.is(SomeComponent)).toBe(true)

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

@lmiller1990
Copy link
Member

Thanks! sorry I did not see these PRs earlier.

@lmiller1990 lmiller1990 merged commit 677ba31 into vuejs:dev Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants