Skip to content

Pass an empty object to scoped slots #1660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

sirlancelot
Copy link
Contributor

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Match how the Vue runtime executes scoped slots. When a scoped slot
accepts and immediately destructures its props, an error will get thrown
if attempting to destructure a value that is undefined.

Match how the Vue runtime executes scoped slots. When a scoped slot
accepts and immediately destructures its props, an error will get thrown
if attempting to destructure a value that is `undefined`.
@lmiller1990
Copy link
Member

Great, thanks! Good job figuring this out, that part of the codebase is pretty gnarly.

@lmiller1990 lmiller1990 merged commit 498382c into vuejs:dev Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants