Skip to content

Upgrade Eslint #1647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 17, 2020
Merged

Upgrade Eslint #1647

merged 7 commits into from
Aug 17, 2020

Conversation

AtofStryker
Copy link
Contributor

@AtofStryker AtofStryker commented Aug 16, 2020

The goal of this PR is to upgrade eslint from 4.x to 7.x (stepwise) to make sure support doesn't go too far out of date.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@AtofStryker AtofStryker marked this pull request as draft August 16, 2020 19:12
@AtofStryker AtofStryker marked this pull request as ready for review August 16, 2020 19:23
"plugin:vue-libs/recommended",
"plugin:flowtype/recommended"
"plugin:flowtype/recommended",
"plugin:vue-libs/recommended"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oddly enough, the order matters here with the recent version of vue-libs

@lmiller1990
Copy link
Member

Wow, 3 major versions behind? Great job.

@lmiller1990 lmiller1990 merged commit 94ee38d into vuejs:dev Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants