Docs: deprecations #1557
Merged
Docs: deprecations #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
commented
May 24, 2020
afontcu
reviewed
May 24, 2020
Co-authored-by: Adrià Fontcuberta <[email protected]>
Co-authored-by: Adrià Fontcuberta <[email protected]>
Co-authored-by: Adrià Fontcuberta <[email protected]>
Co-authored-by: Adrià Fontcuberta <[email protected]>
|
@afontcu thanks for this (you can see I didn't really proofread it, just threw something together). I'll clean it up based on your suggestions today (after work). |
Co-authored-by: Adrià Fontcuberta <[email protected]>
Co-authored-by: Adrià Fontcuberta <[email protected]>
|
Ok @afontcu I think we should be good? |
Sorry it took me a while to get back to you :) This looks cool! |
afontcu
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should have done this for V1. Anyway, better late than ever. Let's provide a solid "this is how you migrate" docs - some of the deprecation messages are unclear or difficult to understand.